fix(external-issues): Convert ticketRuleModal API request to async/await#118269
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ no issues found |
ryan953
reviewed
Jun 23, 2026
| query: initialConfigQuery, | ||
| }), | ||
| (existingData: IntegrationIssueConfig | undefined) => | ||
| data ? (data as IntegrationIssueConfig) : existingData |
Member
There was a problem hiding this comment.
@cursor do we need the type hint in here? would this work:
Suggested change
| data ? (data as IntegrationIssueConfig) : existingData | |
| data ? data : existingData |
Contributor
There was a problem hiding this comment.
Perfect! I've removed the redundant type assertion.
You're correct - since data is already typed as any from the api.requestPromise() call, the explicit cast to IntegrationIssueConfig doesn't provide any meaningful type safety. The callback's return type signature (IntegrationIssueConfig | undefined) already constrains what can be returned, so the simplified version data ? data : existingData works just as well.
The change has been committed and pushed to the PR.
…uleModal Co-authored-by: Ryan Albrecht <ryan@ryanalbrecht.ca>
ryan953
approved these changes
Jun 23, 2026
ryan953
added
the
Trigger: getsentry tests
sehr-m
pushed a commit
that referenced
this pull request
Jun 23, 2026
…ait (#118269) Refactors the `refetchWithDynamicFields` function in `static/app/components/externalIssues/ticketRuleModal.tsx`. This change addresses the `no-callback-api-request` violation (FRONTEND-TSC-36) by replacing the deprecated callback-based `api.request()` with `api.requestPromise()` using `async/await` and a `try/catch/finally` block. This ensures consistent error handling and aligns with modern frontend API interaction patterns. Also removes now-unused `RequestOptions` and `ResponseMeta` imports. <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. Fixes [FRONTEND-TSC-36](https://sentry.sentry.io/issues/7553133131/?seerDrawer=true) --------- Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Ryan Albrecht <ryan@ryanalbrecht.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the
refetchWithDynamicFieldsfunction instatic/app/components/externalIssues/ticketRuleModal.tsx.This change addresses the
no-callback-api-requestviolation (FRONTEND-TSC-36) by replacing the deprecated callback-basedapi.request()withapi.requestPromise()usingasync/awaitand atry/catch/finallyblock. This ensures consistent error handling and aligns with modern frontend API interaction patterns.Also removes now-unused
RequestOptionsandResponseMetaimports.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes FRONTEND-TSC-36