fix(resultGrid): Migrate api.request to api.requestPromise#118265
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introduced
This is informational only and does not block the PR. |
ryan953
approved these changes
Jun 23, 2026
ryan953
added
the
Trigger: getsentry tests
…ponses Implement cleanup function in useEffect to prevent stale data from overwriting newer results. Uses an isCancelled flag that is checked before calling setState, ensuring that only the most recent request updates the component state. This fixes the race condition where slower requests could complete after faster ones when dependencies change rapidly, particularly when persistInFlight is enabled. Co-authored-by: Ryan Albrecht <ryan@ryanalbrecht.ca>
github-actions
Bot
removed
the
Trigger: getsentry tests
ryan953
approved these changes
Jun 23, 2026
ryan953
added
the
Trigger: getsentry tests
sehr-m
pushed a commit
that referenced
this pull request
Jun 23, 2026
Refactors the API call in `static/app/components/resultGrid.tsx` to comply with the `no-callback-api-request` rule. Previously, the component used `api.request` with `success` and `error` callbacks. This change migrates the call to use `api.requestPromise` within an `async` function and a `try/catch` block, leveraging modern `async/await` patterns. `includeAllArgs: true` was added to `requestPromise` options to ensure that response headers (specifically the 'Link' header for pagination) remain accessible, preserving existing functionality. <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. Fixes [FRONTEND-TSC-35](https://sentry.sentry.io/issues/7553133111/?seerDrawer=true) --------- Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Ryan Albrecht <ryan@ryanalbrecht.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the API call in
static/app/components/resultGrid.tsxto comply with theno-callback-api-requestrule.Previously, the component used
api.requestwithsuccessanderrorcallbacks. This change migrates the call to useapi.requestPromisewithin anasyncfunction and atry/catchblock, leveraging modernasync/awaitpatterns.includeAllArgs: truewas added torequestPromiseoptions to ensure that response headers (specifically the 'Link' header for pagination) remain accessible, preserving existing functionality.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes FRONTEND-TSC-35