ref(preprod): Remove snapshot feature flags and backend gating#118263
Merged
NicoHinderling merged 1 commit intoJun 23, 2026
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
Bot
added
the
Scope: Backend
NicoHinderling
force-pushed
the
nico/ref/preprod-remove-snapshot-flags-backend
branch
from
792e374 to
6400018
Compare
trevor-e
approved these changes
Jun 23, 2026
Base automatically changed from
nico/ref/preprod-remove-snapshot-flags-frontend
to
master
June 23, 2026 18:38
The preprod snapshot features are now GA. Unregister the three flags in temporary.py and remove every backend check for: - organizations:preprod-snapshots - organizations:preprod-snapshot-pr-comments - organizations:preprod-selective-base-snapshots The 403 "Feature not enabled" guards are dropped, the allow_selective lookups become unconditional, and the snapshot PR-comment task no longer gates on the flag (the project-option and VCS guards are kept). Tests that asserted the now-removed flag-OFF behavior are deleted; the rest have their with self.feature(...) wrappers removed. Stacked on top of the frontend flag-removal PR.
NicoHinderling
force-pushed
the
nico/ref/preprod-remove-snapshot-flags-backend
branch
from
6400018 to
4628765
Compare
NicoHinderling
deleted the
nico/ref/preprod-remove-snapshot-flags-backend
branch
sehr-m
pushed a commit
that referenced
this pull request
Jun 23, 2026
The preprod snapshot features are GA, so this unregisters the three
flags in `temporary.py` and removes all backend gating on them:
- `organizations:preprod-snapshots`
- `organizations:preprod-snapshot-pr-comments`
- `organizations:preprod-selective-base-snapshots`
Behavior changes:
- The snapshot endpoints (create/detail/delete, archive, image-detail,
latest-base, upload-options) no longer short-circuit with `403
{"detail": "Feature not enabled"}` for orgs without `preprod-snapshots`
— they now always serve, the same as the existing `IS_DEV` path.
Existing auth/project-access checks are unchanged.
- Selective snapshots are now always eligible as comparison bases.
`find_base_snapshot_artifact` previously excluded selective bases unless
`preprod-selective-base-snapshots` was set; the `allow_selective`
parameter and its filter branch are removed, and the now-dead
`allow_selective` plumbing in the create handler, recompare, and
build-details is gone.
- The snapshot PR-comment task no longer gates on
`preprod-snapshot-pr-comments`. Its other early-returns — the
`sentry:preprod_snapshot_pr_comments_enabled` project option and the
missing-commit-comparison / PR-info / client checks — are kept.
Tests that asserted the old flag-OFF behavior (403 responses, the
`feature_disabled` skip, the selective-base-excluded-by-default case)
are deleted or updated to the always-on behavior; the remaining tests
just lose their `with self.feature(...)` wrappers.
Stacked on top of the frontend flag-removal PR (#118262) and should
merge after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preprod snapshot features are GA, so this unregisters the three flags in
temporary.pyand removes all backend gating on them:organizations:preprod-snapshotsorganizations:preprod-snapshot-pr-commentsorganizations:preprod-selective-base-snapshotsBehavior changes:
403 {"detail": "Feature not enabled"}for orgs withoutpreprod-snapshots— they now always serve, the same as the existingIS_DEVpath. Existing auth/project-access checks are unchanged.find_base_snapshot_artifactpreviously excluded selective bases unlesspreprod-selective-base-snapshotswas set; theallow_selectiveparameter and its filter branch are removed, and the now-deadallow_selectiveplumbing in the create handler, recompare, and build-details is gone.preprod-snapshot-pr-comments. Its other early-returns — thesentry:preprod_snapshot_pr_comments_enabledproject option and the missing-commit-comparison / PR-info / client checks — are kept.Tests that asserted the old flag-OFF behavior (403 responses, the
feature_disabledskip, the selective-base-excluded-by-default case) are deleted or updated to the always-on behavior; the remaining tests just lose theirwith self.feature(...)wrappers.Stacked on top of the frontend flag-removal PR (#118262) and should merge after it.