chore(billing): Added snapshot tests for billing details widget(REVENG-245)#118260
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 4 new type safety issues introduced
Non-null assertions (
Type assertions (
This is informational only and does not block the PR. |
dashed
approved these changes
Jun 23, 2026
mtopo27
approved these changes
Jun 23, 2026
| </ThemeProvider> | ||
| ); | ||
| }, | ||
| name => ({tags: {area: 'billing', scenario: name}}) |
Contributor
There was a problem hiding this comment.
not a strong preference, but you can probably omit scenario:name b/c it's just a dupe of the display name
| '%s', | ||
| name => { | ||
| const scenario = SCENARIOS[name]!; | ||
| mockUseBillingDetails.mockReturnValue({ |
Contributor
There was a problem hiding this comment.
if you're using this a lot, you could make a centralized mock in tests/js/sentry-test/snapshots/mocks, but only if you're constantly mocking the same thing. We haven't set up anything for where shared domain-specific mocks would go, not sure it's needed in your use case
Member
Author
There was a problem hiding this comment.
will keep in mind as we add tests 👍🏽
sehr-m
pushed a commit
that referenced
this pull request
Jun 23, 2026
…G-245) (#118260) https://linear.app/getsentry/issue/REVENG-245/add-snapshot-tests-to-billing-details-widget-and-enable-ci This PR adds snapshot tests to cover multiple scenarios for the billing details widget on the subscription page, and integrates these snapshots with CI for automatic diffing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/getsentry/issue/REVENG-245/add-snapshot-tests-to-billing-details-widget-and-enable-ci
This PR adds snapshot tests to cover multiple scenarios for the billing details widget on the subscription page, and integrates these snapshots with CI for automatic diffing.