fix(plugins): Block deprecated plugins from test-fire notifications#118257
Merged
Christinarlong merged 2 commits intoJun 23, 2026
Merged
Conversation
Deprecated notification plugins (e.g. Twilio) could be test-fired via "Send Test Notification" in alert rule config. The test fire silently failed but returned 200, misleading users into thinking their notification worked. Check the action's plugin slug against HIDDEN_PLUGINS before attempting to fire, and return a clear deprecation error in both the legacy (ProjectRuleActions) and new (OrganizationTestFireActions) endpoints. ISWF-2908
github-actions
Bot
added
the
Scope: Backend
…dation The test-fire endpoints validate action payloads through serializers before reaching our deprecation check. Enable twilio on the test project so it appears as a valid service choice, and fix the webhook config to use target_type=None matching the actual DB schema.
ceorourke
approved these changes
Jun 23, 2026
Christinarlong
deleted the
Christinarlong/fix-deprecated-plugin-test-notifications
branch
sehr-m
pushed a commit
that referenced
this pull request
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deprecated notification plugins (e.g. Twilio) can be test-fired via "Send Test Notification" in alert rule configuration.
HIDDEN_PLUGINS) from being test-fired in the legacyProjectRuleActionsendpointOrganizationTestFireActionsendpointComplements #118206 which removes deprecated plugins from the available services list.
Fixes ISWF-2908