Skip to content

ref(cells) Use signupLocalities in UI code#118240

Merged
markstory merged 8 commits into
masterfrom
fix-org-create-ui
Jun 24, 2026
Merged

ref(cells) Use signupLocalities in UI code#118240
markstory merged 8 commits into
masterfrom
fix-org-create-ui

Conversation

@markstory

Copy link
Copy Markdown
Member

Update relocations and organization create to use the singupLocalities attribute that will be exposed in __initialData #118204.

These changes also remove relocationConfig as with signup_visible we can make relocationConfig redundant. I have also converted relocations from storing URLs in its state to using locality names. This aligns the implementation between relocations and org create.

Refs INFRENG-350

@markstory markstory requested a review from a team as a code owner June 23, 2026 15:14
@linear-code

linear-code Bot commented Jun 23, 2026

Copy link
Copy Markdown

INFRENG-350

@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b939934. Configure here.

Comment thread static/app/views/organizationCreate/index.tsx
Comment thread static/app/views/relocation/relocation.tsx
Base automatically changed from fix-org-create-localities to master June 23, 2026 19:16
@markstory markstory requested a review from a team as a code owner June 23, 2026 19:16
@markstory markstory requested a review from a team June 23, 2026 19:16
@markstory markstory merged commit 0bf1c5e into master Jun 24, 2026
73 checks passed
@markstory markstory deleted the fix-org-create-ui branch June 24, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants