feat(scraps): add SplitPanel core component#118230
Draft
priscilawebdev wants to merge 1 commit into
Draft
Conversation
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-gxq2a12p4.sentry.dev |
b57faa6 to
b42a3c5
Compare
Add a two-pane SplitPanel layout primitive with a draggable, keyboard- accessible divider that resizes one pane while the other fills the remaining space. Supports horizontal/vertical (and responsive) orientation, start/end placement, size persistence via initialSize/ onResizeEnd, and a single-pane mode when fill is omitted. Includes MDX stories (with stateful demos extracted to __stories__ so the formatter doesn't flatten them) and tests, and points the existing conversation and replay layouts at the new import path.
b42a3c5 to
85ba6cf
Compare
Contributor
|
@priscilawebdev have you tested this on a touch device? I'd like to make sure that fingers can easily trigger that drag handler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
SplitPanelinto the core design system (@sentry/scraps/splitPanel) with stories, tests, and an API reference. Migrates the conversation and replay layout consumers to the new path and removes the old component.