Skip to content

ref(o11y): Shim SDK tracing functions in Issue Detection files#117994

Open
alexander-alderman-webb wants to merge 22 commits into
masterfrom
webb/issue-detection/shim-sdk
Open

ref(o11y): Shim SDK tracing functions in Issue Detection files#117994
alexander-alderman-webb wants to merge 22 commits into
masterfrom
webb/issue-detection/shim-sdk

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Use the wrapper that delegates to streaming trace lifecycle API if the option is enabled, and falls back to the existing tracing API otherwise.
This allows us to dogfood the new tracing lifecycle by flipping a boolean flag and to easily revert the experiment.
If successful, the wrapper can be replaced with equivalent SDK API.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 18, 2026
Base automatically changed from webb/add-streaming-shims to master June 23, 2026 15:16

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f98ff66. Configure here.

Comment thread src/sentry/issue_detection/performance_detection.py
Comment thread src/sentry/issue_detection/performance_detection.py
@alexander-alderman-webb alexander-alderman-webb marked this pull request as draft June 23, 2026 18:35
@alexander-alderman-webb alexander-alderman-webb changed the base branch from master to webb/remove-containing-transaction June 24, 2026 09:05
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review June 24, 2026 09:11
with (
metrics.timer("performance.detect_performance_issue", sample_rate=0.01),
sentry_sdk.start_span(op="py.detect_performance_issue", name="none") as sdk_span,
start_span(op="py.detect_performance_issue", name="none") as sdk_span,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was already here, but strange that we're setting a name of "none" 🤔

Base automatically changed from webb/remove-containing-transaction to master June 25, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants