ref(o11y): Shim SDK tracing functions in Issue Detection files#117994
Open
alexander-alderman-webb wants to merge 22 commits into
Open
ref(o11y): Shim SDK tracing functions in Issue Detection files#117994alexander-alderman-webb wants to merge 22 commits into
alexander-alderman-webb wants to merge 22 commits into
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f98ff66. Configure here.
cvxluo
approved these changes
Jun 24, 2026
ericapisani
approved these changes
Jun 24, 2026
| with ( | ||
| metrics.timer("performance.detect_performance_issue", sample_rate=0.01), | ||
| sentry_sdk.start_span(op="py.detect_performance_issue", name="none") as sdk_span, | ||
| start_span(op="py.detect_performance_issue", name="none") as sdk_span, |
Member
There was a problem hiding this comment.
I know this was already here, but strange that we're setting a name of "none" 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Use the wrapper that delegates to streaming trace lifecycle API if the option is enabled, and falls back to the existing tracing API otherwise.
This allows us to dogfood the new tracing lifecycle by flipping a boolean flag and to easily revert the experiment.
If successful, the wrapper can be replaced with equivalent SDK API.