Skip to content

fix(typing): Remove sentry.incidents.serializers from the mypy weaklist#115232

Merged
kcons merged 4 commits into
masterfrom
kcons/fixier
May 11, 2026
Merged

fix(typing): Remove sentry.incidents.serializers from the mypy weaklist#115232
kcons merged 4 commits into
masterfrom
kcons/fixier

Conversation

@kcons
Copy link
Copy Markdown
Member

@kcons kcons commented May 8, 2026

Fairly straightforward.

@kcons kcons requested review from a team as code owners May 8, 2026 21:02
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 8, 2026
@kcons kcons changed the title fix(types): Remove sentry.incidents.serializers from the mypy weaklist fix(typing): Remove sentry.incidents.serializers from the mypy weaklist May 8, 2026
@kcons kcons marked this pull request as draft May 8, 2026 21:05
@kcons
Copy link
Copy Markdown
Member Author

kcons commented May 8, 2026

Shoot. prek run mypy doesn't adjust caching when you change the weaklist.
And now I'm remembering why this is untyped; the base class scenario is A Whole Thing I've dealt with before.

@kcons kcons marked this pull request as ready for review May 8, 2026 23:11
Copy link
Copy Markdown
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I'm sorry to report I am close to being able to delete all these files!

@kcons kcons enabled auto-merge (squash) May 11, 2026 18:25
@kcons kcons merged commit 606d1a4 into master May 11, 2026
86 checks passed
@kcons kcons deleted the kcons/fixier branch May 11, 2026 18:40
nikkikapadia pushed a commit that referenced this pull request May 12, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants