feat(data-collection): Port Rails log subscriber by sl0thentr0py · Pull Request #3034 · getsentry/sentry-ruby

sl0thentr0py · 2026-07-23T14:34:02Z

Remove ParameterFilter usage completely
Nested payloads will now not be scrubbed (we will revisit this later if necessary)

Issues

Resolves: feat(pii): Wire Rails log-subscriber data (active_record, mailer, active_job) #3006
Resolves: RUBY-194

linear-code · 2026-07-23T14:34:24Z

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b4853e5. Configure here.}

* Remove `ParameterFilter` usage completely * Nested payloads will now **not** be scrubbed (we will revisit this later if necessary)

solnic · 2026-07-30T14:33:26Z

      # @return [Hash] a new filtered hash, or an empty hash when collection is off
      def filter(values, cookie: false)
        return {} if mode == :off
+        return {} unless values.is_a?(Hash)


Why is this needed here? It can hide bugs or unwanted behaviors.

failing gracefully since we cannot trust future call sites (or contract changes in Rails) is better than Sentry causing 500s in userland

@sl0thentr0py OK but shouldn't this guard be located in places where we call filter? I'm just thinking that having it here may bite us potentially in the future.

ok i'll move it to callsites

sl0thentr0py force-pushed the neel/data-collection/rails-logs branch from d8a5cd0 to f24bdc4 Compare July 23, 2026 14:35

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread sentry-ruby/lib/sentry/data_collection/key_value_collection.rb

Comment thread sentry-rails/lib/sentry/rails/railtie.rb Outdated

Comment thread sentry-rails/lib/sentry/rails/log_subscribers/active_job_subscriber.rb Outdated

sentry Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread sentry-rails/lib/sentry/rails/railtie.rb Outdated

sl0thentr0py force-pushed the neel/data-collection/rails-logs branch 3 times, most recently from 5aff1d4 to 737323c Compare July 23, 2026 18:18

sentry-warden Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread sentry-rails/lib/sentry/rails/log_subscribers/action_controller_subscriber.rb

sl0thentr0py force-pushed the neel/data-collection/rails-logs branch from 737323c to 0b56b5b Compare July 23, 2026 19:08

sentry Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread sentry-ruby/lib/sentry/data_collection.rb Outdated

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread sentry-ruby/lib/sentry/data_collection.rb Outdated

sl0thentr0py force-pushed the neel/data-collection/rails-logs branch from 0b56b5b to 0f295fd Compare July 23, 2026 19:12

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread sentry-rails/lib/sentry/rails/log_subscribers/active_job_subscriber.rb Outdated

sl0thentr0py force-pushed the neel/data-collection/rails-logs branch 2 times, most recently from a94b458 to b4853e5 Compare July 23, 2026 19:37

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread sentry-rails/lib/sentry/rails/controller_transaction.rb Outdated

sentry Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread sentry-rails/lib/sentry/rails/controller_transaction.rb Outdated

sl0thentr0py force-pushed the neel/data-collection/rails-logs branch from b4853e5 to 2926036 Compare July 23, 2026 19:46

sentry Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread sentry-rails/lib/sentry/rails/log_subscribers/active_job_subscriber.rb

feat(data-collection): Port Rails log subscribers

6b771d6

* Remove `ParameterFilter` usage completely * Nested payloads will now **not** be scrubbed (we will revisit this later if necessary)

sl0thentr0py force-pushed the neel/data-collection/rails-logs branch from 2926036 to 6b771d6 Compare July 23, 2026 19:54

sentry-warden Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread sentry-rails/spec/sentry/rails/log_subscribers/active_job_subscriber_spec.rb

solnic reviewed Jul 30, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

sl0thentr0py commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Uh oh!

linear-code Bot commented Jul 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

solnic Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

sl0thentr0py Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

solnic Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

sl0thentr0py Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sl0thentr0py commented Jul 23, 2026 •

edited

Loading