Skip to content

fix(e2e): Fix TestFlight upload after enabling Mac Catalyst on the sample - #6762

Merged
antonis merged 3 commits into
mainfrom
antonis/fix-testflight-catalyst
Sep 22, 2026
Merged

antonis merged 3 commits into
mainfrom
antonis/fix-testflight-catalyst

Conversation

@antonis

@antonis antonis commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix

📜 Description

The sample app now declares SUPPORTS_MACCATALYST = YES (added in #6758 for the Mac Catalyst build job). gym/build_app reads this and treats the app as neither a pure-iOS nor a macOS build, so it skips IPA packaging entirely — No output path received from gym — and the subsequent upload_react_native_sample_to_testflight lane fails with No ipa or pkg file given.

Setting catalyst_platform: "ios" on build_app pins gym to the iOS build, so it packages the iOS .ipa as before.

This is the sample app's fastlane release config only — it does not affect the published @sentry/react-native package or its users.

💡 Motivation and Context

The Upload to Testflight workflow started failing on main immediately after #6758 merged (green on 12d5e0d, failing on 2bf6e2c). Root cause is gym's post-archive packaging gate skipping both the iOS and macOS branches for a Catalyst-capable app when catalyst_platform is unset.

💚 How did you test it?

Tested with a7250b8 that the fix works on CI

📝 Checklist

  • I added tests to verify changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • No breaking changes.

🔮 Next steps

antonis and others added 2 commits September 21, 2026 14:10
The sample app declares SUPPORTS_MACCATALYST = YES (for the Mac Catalyst
build job added in #6758). gym then treats it as neither pure-iOS nor
macOS and skips IPA packaging ("No output path received from gym"),
breaking the TestFlight upload. Set catalyst_platform: "ios" to pin the
iOS build.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Temporary trigger to exercise the TestFlight job on this PR. Revert once
the run is green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • fix(e2e): Fix TestFlight upload after enabling Mac Catalyst on the sample by antonis in #6762
  • fix(ios): Fix Mac Catalyst linking the wrong Sentry.xcframework slice by antonis in #6758
  • chore(deps): bump the codeql-action group across 1 directory with 3 updates by dependabot in #6756
  • chore(deps): bump ruby/setup-ruby from 1.321.0 to 1.324.0 by dependabot in #6757
  • fix(core): Declare optional peer dependencies to resolve phantom imports under strict package managers by antonis in #6729
  • Add missing exports and update public API report by antonis in #6731
  • test(ios): Reenable Session Replay E2E test by antonis in #6737
  • fix(ios): Honor shutdownTimeout on iOS by antonis in #6749

🤖 This preview updates automatically when you update the PR.

@antonis antonis added ready-to-merge Triggers the full CI test suite skip-changelog labels Sep 21, 2026
…anch"

This reverts commit a7250b8.

The temporary trigger did its job: the TestFlight job ran green on this
PR, confirming the catalyst_platform fix produces an IPA and uploads.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@antonis
antonis marked this pull request as ready for review September 21, 2026 12:22
@sentry

sentry Bot commented Sep 21, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Sentry RN io.sentry.reactnative.sample 8.27.0 (107) Release

⚙️ sentry-react-native Build Distribution Settings

@antonis
antonis merged commit 6b0fba4 into main Sep 22, 2026
102 of 103 checks passed
@antonis
antonis deleted the antonis/fix-testflight-catalyst branch September 22, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants