Repository navigation
test(nuxt): Cover pages router instrumentation - #24583
Draft
vansh-nagar wants to merge 1 commit into
Draft
vansh-nagar wants to merge 1 commit into
vansh-nagar wants to merge 1 commit into
Conversation
s1gr1d
reviewed
Sep 29, 2026
s1gr1d
left a comment
s1gr1d
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR!
We already cover pages-router instrumentation in the nuxt-4 E2E app. The remaining value of a unit test here is covering the branches that E2E doesn't cover: a test that browserTracingIntegration is not called and addIntegration is only called for the vue integration path (similar to 'does not create router instrumentation without an initialized client'). But we need coverage for if (sentryClient && '$router' in nuxtApp).
Fixes getsentry#13813 Co-Authored-By: OpenAI Codex <codex@openai.com>
vansh-nagar
force-pushed
the
fix/nuxt-pages-router-tests
branch
from
September 29, 2026 18:36
0149c63 to
1a80479
Compare
Member
|
This PR is still in draft, do you plan to still add something to it? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nuxt client plugin's pages-router integration had no direct unit coverage after the earlier SDK-level BrowserTracing assertion was removed.
This adds focused checks that the initialized client receives BrowserTracing with Nuxt's router and path-based route labels, while an uninitialized client does not create the integration.
Fixes #13813