feat(deno): add google-genai integration - #22469
Merged
Merged
Conversation
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
July 21, 2026 20:30
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 21, 2026 20:55
a3bda7b to
af2805c
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 21, 2026 21:31
af2805c to
46512ae
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+69
to
+72
| Deno.test('google-genai instrumentation: orchestrion @google/genai:generate-content channel produces a nested gen_ai span', async () => { | ||
| resetGlobals(); | ||
| const sink = transactionSink(); | ||
| init({ |
Contributor
There was a problem hiding this comment.
Bug: A module-level installedIntegrations array is not cleared between tests, causing subsequent init() calls to skip setup and leading to test failures.
Severity: MEDIUM
Suggested Fix
The installedIntegrations array should be cleared between tests. This can be done by exporting a reset function from @sentry/core that clears the array and then calling this new function within resetGlobals(). This will ensure each test runs in a clean state.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/deno-integration-tests/suites/orchestrion-google-genai/test.ts#L69-L72
Potential issue: A module-level array, `installedIntegrations`, is not cleared between
tests, even when `resetGlobals()` is called. When a second test in the same file calls
`init()`, the integration's `setupOnce()` function is skipped because the integration
name is already present in the array from the first test's execution. This prevents
diagnostic channel subscriptions from being set up for the second test. Consequently,
the test times out waiting for a transaction that is never created, causing a test
failure.
Also affects:
packages/core/src/integration.ts:10packages/core/src/integration.ts:117~119
Did we get this right? 👍 / 👎 to inform future reviews.
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 21, 2026 21:42
46512ae to
46e8ba9
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 22, 2026 00:51
46e8ba9 to
a2edc7e
Compare
JPeer264
approved these changes
Jul 22, 2026
nicohrubec
approved these changes
Jul 22, 2026
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 22, 2026 14:42
a2edc7e to
ac2a96d
Compare
isaacs
requested review from
chargome,
msonnb and
mydea
and removed request for
a team
July 22, 2026 14:42
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 22, 2026 22:02
ac2a96d to
dd3e8b8
Compare
Contributor
size-limit report 📦
|
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 23, 2026 14:29
dd3e8b8 to
d8bf614
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 23, 2026 18:10
d8bf614 to
8a0503f
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
2 times, most recently
from
July 23, 2026 21:19
fde4dd2 to
84fe78c
Compare
Comment on lines
+64
to
+72
| Deno.test('google-genai instrumentation: orchestrion @google/genai:generate-content channel produces a nested gen_ai span', async () => { | ||
| resetGlobals(); | ||
| const sink = transactionSink(); | ||
| init({ | ||
| dsn: 'https://username@domain/123', | ||
| tracesSampleRate: 1, | ||
| beforeSendTransaction: sink.beforeSendTransaction, | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Bug: The module-level subscribed flag in the google-genai integration is not reset between tests, causing subsequent init() calls in the same file to fail to set up tracing.
Severity: MEDIUM
Suggested Fix
Export a reset function from the google-genai.ts integration module that sets the subscribed flag back to false. Call this new reset function from within the resetGlobals() helper in the test suite to ensure a clean state between test runs.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/deno-integration-tests/suites/orchestrion-google-genai/test.ts#L64-L72
Potential issue: The `google-genai.ts` integration uses a module-level `subscribed` flag
to prevent re-subscribing to diagnostics channels. In the Deno test environment, tests
within the same file share module scope. The first test sets `subscribed` to `true`. A
`resetGlobals()` function is called between tests, but it fails to reset this
module-level flag. Consequently, when the second test calls `init()`, the integration's
`setupOnce()` function sees that `subscribed` is already `true` and exits prematurely,
skipping the channel subscription logic. This causes the second test to fail its
assertion, as no AI span is created.
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
2 times, most recently
from
July 23, 2026 22:47
9ebec22 to
35a3aec
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 24, 2026 01:24
35a3aec to
5718dfb
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 24, 2026 14:31
5718dfb to
08f6136
Compare
Comment on lines
+57
to
+62
| Deno.test('google-genai instrumentation: included in default integrations (Deno 2.8.0+)', () => { | ||
| resetGlobals(); | ||
| const client = init({ dsn: 'https://username@domain/123' }) as DenoClient; | ||
| const names = client.getOptions().integrations.map(i => i.name); | ||
| assert(names.includes('Google_GenAI'), `Google_GenAI should be in defaults, got ${names.join(', ')}`); | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: The test unconditionally asserts Google_GenAI is a default integration, but it's only included on Deno 2.8.0+. This will cause test failures on older Deno versions.
Severity: MEDIUM
Suggested Fix
Conditionally skip the test assertion if the Deno version is less than 2.8.0. This can be achieved by checking the MODULE_REGISTER_HOOKS_SUPPORTED flag within the test file and only running the assertion if it's true. This will align the test's logic with the SDK's conditional inclusion logic.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/deno-integration-tests/suites/orchestrion-google-genai/test.ts#L57-L62
Potential issue: The `googleGenAIChannelIntegration()` is conditionally added to the
default integrations only on Deno versions 2.8.0 and newer, controlled by the
`MODULE_REGISTER_HOOKS_SUPPORTED` flag. However, the corresponding integration test
unconditionally asserts that the `'Google_GenAI'` integration is present in the
defaults. This discrepancy will cause the test to fail when run in an environment with a
Deno version older than 2.8.0, as the test suite does not enforce a minimum Deno
version. This pattern is reportedly present in over 20 other integration tests,
indicating a systemic issue.
Also affects:
packages/deno/src/sdk.ts:96~102
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 24, 2026 15:13
08f6136 to
9b9fef7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.