ref(android): Remove unused TimeSpan.start() - #6089
Merged
Merged
Conversation
TimeSpan.start() had no production callers. Every start time in the SDK is set through setStartedAt(uptimeMs), which does the same thing for a caller passing SystemClock.uptimeMillis(). The tests that used it now call setStartedAt directly. Three AppStartMetricsTest cases also called start() and stop() immediately before overwriting both with setStartedAt/setStoppedAt; those calls were dead and are dropped. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
September 10, 2026 09:00
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
📲 Install BuildsAndroid
|
runningcode
commented
Sep 10, 2026
markushi
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Removes
TimeSpan.start(), which had no production callers, along with its 13 test call sites.💡 Motivation and Context
Dead code
💚 How did you test it?
:sentry-android-core:testReleaseUnitTestfor the touched classes — 211 tests, all passing.spotlessApply apiDumpis clean.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog