fix(core): [Data Collection 23] Support WebSocket URL parsing - #6064
Draft
adinauer wants to merge 4 commits into
Draft
fix(core): [Data Collection 23] Support WebSocket URL parsing#6064adinauer wants to merge 4 commits into
adinauer wants to merge 4 commits into
Conversation
Treat ws and wss as valid hierarchical URIs without requiring JVM URL handlers. This preserves Ktor WebSocket span descriptions and query filtering instead of falling back to an unknown URL. Refs #5666 Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Sep 7, 2026
Propagate the corrected OkHttp Set-Cookie fixture through the Data Collection PR stack. Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
Propagate the OpenTelemetry span-description revert from the preceding stack branch. Co-Authored-By: Claude <noreply@anthropic.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Data Collection)
📜 Description
Allow
UrlUtilsto parse structurally validwsandwssURIs without requiring a JVMURLStreamHandler. Keep the existing handler-based validation for every other scheme to preserve support for built-in and customer-installed handlers.💡 Motivation and Context
Java WebSocket clients consume
URIdirectly and generally do not install global URL handlers. Converting a valid WebSocket URI withURI.toURL()therefore commonly fails, causing Ktor WebSocket span descriptions and request URLs to fall back to unknown values.Refs #5666
💚 How did you test it?
./gradlew :sentry:test --tests='io.sentry.util.UrlUtilsTest' --rerun-tasks --no-parallel --no-configuration-cache --max-workers=1./gradlew spotlessApply apiDump --no-parallel --no-configuration-cache --max-workers=1git diff --check📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.