perf: Let HostnameCache worker thread idle out (JAVA-653)#5817
Draft
runningcode wants to merge 2 commits into
Draft
perf: Let HostnameCache worker thread idle out (JAVA-653)#5817runningcode wants to merge 2 commits into
runningcode wants to merge 2 commits into
Conversation
📲 Install BuildsAndroid
|
This was referenced Jul 22, 2026
HostnameCache used Executors.newSingleThreadExecutor, whose worker thread stays alive for the life of the process even though the cache refreshes at most once every 5 hours. Use a ThreadPoolExecutor with a keep-alive and allowCoreThreadTimeOut(true) so the thread terminates when idle and is recreated on the next refresh. Keeping a dedicated executor (rather than sharing one) preserves the blocking future.get(1s) timeout behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
runningcode
force-pushed
the
no/perf/hostname-cache-idle-thread
branch
from
July 22, 2026 15:53
b0b4168 to
b03da86
Compare
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb95ded | 317.51 ms | 369.08 ms | 51.57 ms |
| 2124a46 | 319.19 ms | 415.04 ms | 95.85 ms |
| c3ee041 | 310.64 ms | 361.90 ms | 51.26 ms |
| dcc6bbf | 382.58 ms | 462.13 ms | 79.54 ms |
| 7a19fee | 315.46 ms | 368.62 ms | 53.16 ms |
| 9054d65 | 330.94 ms | 403.24 ms | 72.30 ms |
| d500866 | 326.13 ms | 378.70 ms | 52.58 ms |
| ad8da22 | 365.86 ms | 427.00 ms | 61.14 ms |
| ed33deb | 337.52 ms | 484.06 ms | 146.54 ms |
| d15471f | 310.26 ms | 377.04 ms | 66.78 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb95ded | 0 B | 0 B | 0 B |
| 2124a46 | 1.58 MiB | 2.12 MiB | 551.51 KiB |
| c3ee041 | 0 B | 0 B | 0 B |
| dcc6bbf | 1.58 MiB | 2.12 MiB | 553.10 KiB |
| 7a19fee | 0 B | 0 B | 0 B |
| 9054d65 | 1.58 MiB | 2.29 MiB | 723.38 KiB |
| d500866 | 0 B | 0 B | 0 B |
| ad8da22 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| ed33deb | 1.58 MiB | 2.13 MiB | 559.52 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
HostnameCachecreated its worker withExecutors.newSingleThreadExecutor, whose thread stays alive for the entire process lifetime — even though the cache only refreshes once every 5 hours (and the hostname lookup runs for at most 1 second). It now uses aThreadPoolExecutor(core = max = 1) with a 30s keep-alive andallowCoreThreadTimeOut(true), so the worker thread self-terminates when idle and is recreated on the next refresh.The cache keeps its own dedicated executor rather than sharing the SDK-wide one on purpose:
updateCache()blocks onfuture.get(1s), and running that on a shared executor could spuriously time out when the executor is busy with other work.💡 Motivation and Context
Part of reducing the number of threads created by the SDK: JAVA-653.
On the JVM, any app that sends events with
attachServerNameenabled (the default off Android) kept this thread alive 24/7 for what is effectively one DNS lookup every 5 hours.💚 How did you test it?
New
HostnameCacheTestasserting the executor is configured to time out its core thread, plus the existingMainEventProcessorTesthostname coverage.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Related PRs in this effort: RateLimiter (#5814), LifecycleWatcher (#5819), performance collector (#5816), batch processors (#5818).
🤖 Generated with Claude Code