Skip to content

ci: Remove model override from warden.toml - #5419

Merged
jamescrosswell merged 1 commit into
mainfrom
ci/warden-remove-model-override
Jul 22, 2026
Merged

ci: Remove model override from warden.toml#5419
jamescrosswell merged 1 commit into
mainfrom
ci/warden-remove-model-override

Conversation

@jamescrosswell

Copy link
Copy Markdown
Collaborator

Summary

Warden checks have been failing "inexplicably" on PRs (e.g. #5417, #5412). The runner logs show the actual error:

warden: ERROR: code-review - Authentication failed: No API key found for anthropic.

Root cause: the org-level Warden workflow only supplies WARDEN_OPENROUTER_API_KEY, but this repo's warden.toml overrides the default model to anthropic/claude-opus-4-5 — a provider CI has no credentials for. Any skill that actually invoked the model failed with auth_failed; skills with nothing to analyze no-opped and passed, which is why failures looked intermittent (they tracked whether the diff triggered a real model call, not flakiness).

Removing the model override lets skills inherit the org default (currently openrouter/x-ai/grok-4.5), which matches the credentials the org workflow actually provides — and keeps the two from drifting apart again if the org default changes.

#skip-changelog

🤖 Generated with Claude Code

The org-level Warden environment only supplies WARDEN_OPENROUTER_API_KEY,
so pinning the default model to anthropic/claude-opus-4-5 made every skill
that actually invoked the model fail with auth_failed. Dropping the
override lets skills inherit the org default model, which matches the
credentials CI actually has.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jamescrosswell
jamescrosswell marked this pull request as ready for review July 22, 2026 07:04
@github-actions github-actions Bot added the risk: low PR risk score: low label Jul 22, 2026
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.59%. Comparing base (bd517e9) to head (ea3dd23).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5419      +/-   ##
==========================================
+ Coverage   74.54%   74.59%   +0.04%     
==========================================
  Files         512      512              
  Lines       18666    18666              
  Branches     3659     3659              
==========================================
+ Hits        13915    13923       +8     
+ Misses       3878     3868      -10     
- Partials      873      875       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dingsdax
dingsdax self-requested a review July 22, 2026 07:22
@jamescrosswell jamescrosswell added the skip-changelog Suppress automatic changelog generation via Craft label Jul 22, 2026
@jamescrosswell
jamescrosswell merged commit a9a990b into main Jul 22, 2026
41 checks passed
@jamescrosswell
jamescrosswell deleted the ci/warden-remove-model-override branch July 22, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low PR risk score: low skip-changelog Suppress automatic changelog generation via Craft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants