You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Jared, how about going widget-by-widget and duplicating all renderers, we have one "core" renderer that renders to pixels and we convert that to sixel or ascii based on terminal support? The only thing would probably be the resolution which we can feed to the shared renderer upfront as we'll know our output target already? My assumption is the core difference between ascii and sixel would be the resolution.
Current first-cut keeps per-widget renderers simple and isolated; shared pixel core is a good v2 direction once we have more widget types. Resolution param upfront makes sense. Noted for follow-up.
Opened #1410 with the shared pixel-core renderer — chart-core builds a resolution-independent model, sixel and ascii both consume it, resolution fed upfront per output target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-cut sixel timeseries per-widget tiles.
Closes #1231