Skip to content

Fixed reseller flow Issue#8870

Merged
atavism merged 3 commits into
mainfrom
jigar/fix-reseller-flow
Jun 18, 2026
Merged

Fixed reseller flow Issue#8870
atavism merged 3 commits into
mainfrom
jigar/fix-reseller-flow

Conversation

@jigar-f

@jigar-f jigar-f commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This pull request contains minor refactoring and code clean-up in the Lantern Pro License flow and the Plans screen. The most notable change is the improved navigation logic for users who are already logged in when accessing the Lantern Pro License screen. Additionally, there are several formatting and code style improvements.

Navigation and user flow improvements:

  • Updated the navigation logic in the _PlansState class to immediately push the LanternProLicense screen with the user's email if the user is already logged in, otherwise prompt for email entry.

Code style and formatting clean-up:

  • Reformatted the constructor of LanternProLicense for conciseness.
  • Improved formatting in style assignment for the character counter in the license code input.
  • Reformatted the onActivatePro method signature for readability.
  • Improved logging and navigation logic comments and formatting for clarity in LanternProLicense. [1] [2]

Import order consistency:

  • Reordered imports in plans.dart for better consistency and readability.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Lantern Pro License entry flow from the Plans screen, primarily improving navigation when the user is already logged in, and applies small formatting/cleanup changes in the Lantern Pro License screen.

Changes:

  • Update Plans bottom-sheet action to route directly to LanternProLicense when userLoggedIn is true.
  • Minor formatting refactors in LanternProLicense (constructor, counter style, method signature, and navigation formatting).
  • Import order adjustment in plans.dart.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
lib/features/plans/plans.dart Adds “logged-in shortcut” navigation to the Lantern Pro License screen from the Plans bottom sheet.
lib/features/auth/lantern_pro_license.dart Formatting/cleanup in the license activation UI + clarifying comments/logging around post-activation flow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/features/plans/plans.dart
Comment thread lib/features/auth/lantern_pro_license.dart Outdated
Comment thread lib/features/auth/lantern_pro_license.dart

@atavism atavism left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atavism atavism merged commit 17fcd43 into main Jun 18, 2026
7 checks passed
@atavism atavism deleted the jigar/fix-reseller-flow branch June 18, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants