Fixed reseller flow Issue#8870
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Lantern Pro License entry flow from the Plans screen, primarily improving navigation when the user is already logged in, and applies small formatting/cleanup changes in the Lantern Pro License screen.
Changes:
- Update Plans bottom-sheet action to route directly to
LanternProLicensewhenuserLoggedInis true. - Minor formatting refactors in
LanternProLicense(constructor, counter style, method signature, and navigation formatting). - Import order adjustment in
plans.dart.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/features/plans/plans.dart | Adds “logged-in shortcut” navigation to the Lantern Pro License screen from the Plans bottom sheet. |
| lib/features/auth/lantern_pro_license.dart | Formatting/cleanup in the license activation UI + clarifying comments/logging around post-activation flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains minor refactoring and code clean-up in the Lantern Pro License flow and the Plans screen. The most notable change is the improved navigation logic for users who are already logged in when accessing the Lantern Pro License screen. Additionally, there are several formatting and code style improvements.
Navigation and user flow improvements:
_PlansStateclass to immediately push theLanternProLicensescreen with the user's email if the user is already logged in, otherwise prompt for email entry.Code style and formatting clean-up:
LanternProLicensefor conciseness.onActivatePromethod signature for readability.LanternProLicense. [1] [2]Import order consistency:
plans.dartfor better consistency and readability.