Skip to content

Add new mount point for docker#190

Merged
avivace merged 1 commit into
gbdev:masterfrom
Les-Wet:add_docker_mount
May 14, 2026
Merged

Add new mount point for docker#190
avivace merged 1 commit into
gbdev:masterfrom
Les-Wet:add_docker_mount

Conversation

@Les-Wet
Copy link
Copy Markdown
Contributor

@Les-Wet Les-Wet commented May 13, 2026

Spent a long while debugging this so making a PR to help others avoid the same. When using the pre-built Docker image, another mount point has to be added to allow the container to see the changes to the unbricked assembly code. The current command in the README will result in the following error (or similar):

[ERROR] (mdbook::preprocess::links): Error updating "{{#include ../../unbricked/vblank-interrupts/main.asm:vblank-interrupt}}", Could not read file for link {{#include ../../unbricked/vblank-interrupts/main.asm:vblank-interrupt}} (/code/src/part2/../../unbricked/vblank-interrupts/main.asm)

And the tutorial will not display the correct code.

This PR adds a mount point to resolve this issue:

--mount "type=bind,source=$(pwd)/unbricked,target=/code/unbricked" 

Building the container locally avoids this problem since it copies the code into the container directly:

COPY . /code

@Les-Wet
Copy link
Copy Markdown
Contributor Author

Les-Wet commented May 13, 2026

Sorry I should specify, this isn't actually changing the dockerfile or image in any way. This is just changing the instructions on how to use it in the README.

@avivace
Copy link
Copy Markdown
Member

avivace commented May 14, 2026

Good catch, thanks @Les-Wet

@avivace avivace merged commit f2c855b into gbdev:master May 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants