Add new mount point for docker#190
Merged
Merged
Conversation
Contributor
Author
|
Sorry I should specify, this isn't actually changing the dockerfile or image in any way. This is just changing the instructions on how to use it in the README. |
Member
|
Good catch, thanks @Les-Wet |
avivace
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spent a long while debugging this so making a PR to help others avoid the same. When using the pre-built Docker image, another mount point has to be added to allow the container to see the changes to the unbricked assembly code. The current command in the README will result in the following error (or similar):
[ERROR] (mdbook::preprocess::links): Error updating "{{#include ../../unbricked/vblank-interrupts/main.asm:vblank-interrupt}}", Could not read file for link {{#include ../../unbricked/vblank-interrupts/main.asm:vblank-interrupt}} (/code/src/part2/../../unbricked/vblank-interrupts/main.asm)And the tutorial will not display the correct code.
This PR adds a mount point to resolve this issue:
--mount "type=bind,source=$(pwd)/unbricked,target=/code/unbricked"Building the container locally avoids this problem since it copies the code into the container directly:
COPY . /code