You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for flagging this. I checked current master: AsyncFileSystem._mv_file already exists, and GCSFS overrides it for its atomic move path, but synchronous AbstractFileSystem.mv still calls copy followed by rm and there is no corresponding sync mv_file hook.
This draft is the sync counterpart: file-only moves go through the new default mv_file (which preserves copy/delete behavior and can be overridden by a backend), while directory moves retain the existing recursive copy/remove path. The regression test verifies that mv calls an override. If you were referring to a pending sync implementation elsewhere, please point me to it and I'll compare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2017
Summary
mv_fileimplementation that preserves the existing copy/delete behaviormv_fileso filesystems can provide an atomic overrideValidation
ruff format fsspec/spec.py fsspec/implementations/tests/test_memory.pyruff check fsspec/spec.py fsspec/implementations/tests/test_memory.pypytest fsspec/implementations/tests/test_memory.py -qpytest fsspec/tests/abstract/mv.py -qgit diff --checkPrepared with AI assistance; I reviewed the implementation and validation output.