Skip to content

chore(deps-dev): bump postcss from 8.5.23 to 8.5.24 in /web-ui - #1123

Merged
frankbria merged 1 commit into
mainfrom
dependabot/npm_and_yarn/web-ui/postcss-8.5.24
Aug 10, 2026
Merged

chore(deps-dev): bump postcss from 8.5.23 to 8.5.24 in /web-ui#1123
frankbria merged 1 commit into
mainfrom
dependabot/npm_and_yarn/web-ui/postcss-8.5.24

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 10, 2026

Copy link
Copy Markdown
Contributor

Bumps postcss from 8.5.23 to 8.5.24.

Release notes

Sourced from postcss's releases.

8.5.24

  • Preserve the BOM after the processing (by @​hdimer).
Changelog

Sourced from postcss's changelog.

8.5.24

  • Preserve the BOM after the processing (by @​hdimer).
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [postcss](https://github.com/postcss/postcss) from 8.5.23 to 8.5.24.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.5.23...8.5.24)

---
updated-dependencies:
- dependency-name: postcss
  dependency-version: 8.5.24
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Aug 10, 2026
@frankbria

Copy link
Copy Markdown
Owner

Dependabot Triage — PR #1123: postcss 8.5.23 → 8.5.24 (/web-ui)

Classification

  • Update type: Routine low-impact (dev dependency, patch)
  • Security urgency: Low
  • Supply-chain risk: Low

Key observations

  • Bumps the top-level postcss only, from 8.5.23 to 8.5.24. The newest postcss advisory (GHSA-fxqj-rqcc-2cmp) is first patched in 8.5.23, so the top-level copy was already clean before this PR. No advisory rides on it.
  • Diff is confined to postcss in package.json + lockfile; zero lines touching next or sharp. No new packages, no lifecycle scripts.

⚠️ This does not replace #1087

Dependabot closed #1087 as "updatable in another way" and opened this in its place. It is not an equivalent substitute. #1087 fixed the nested node_modules/next/node_modules/postcss pinned by next 16.2.12 — which is where the live exposure is — plus sharp. Still outstanding after this PR merges:

  • GHSA-r28c-9q8g-f849 (high) — postcss path traversal in source-map auto-loading
  • GHSA-6g55-p6wh-862q (high) — postcss arbitrary file read via sourceMappingURL
  • GHSA-qx2v-qp2m-jg93 (high) — postcss XSS via unescaped </style>
  • GHSA-f88m-g3jw-g9cj (high) — sharp inherited libvips CVEs (sharp < 0.35.0)

Confirmed against the current lockfile with npm audit. A manual next upgrade is being raised separately to recover the dropped fixes.

Recommendation

Merge now — harmless on its own, just not a security fix.


Supply-chain triage per the reviewing-dependabot-prs skill.

@frankbria

Copy link
Copy Markdown
Owner

Follow-up filed: #1124 — the four high-severity advisories #1087 would have fixed are still live, and this PR does not cover them. Tracked there with a reproduction and the blocker (next 16.3.0 breaks the type-check with 27 errors in test files).

@frankbria
frankbria merged commit b53f994 into main Aug 10, 2026
12 of 13 checks passed
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/web-ui/postcss-8.5.24 branch August 10, 2026 03:33
frankbria added a commit that referenced this pull request Aug 10, 2026
…ies (#1124) (#1132)

* fix(web-ui): upgrade next to 16.3 to clear four high-severity advisories (#1124)

Four high-severity advisories were live in web-ui. The PR that would have fixed
them (#1087) was closed by Dependabot itself as "updatable in another way", and
its replacement (#1123) bumped only top-level postcss — which was never the
exposure. The vulnerable copy was nested at next/node_modules/postcss, pinned by
next 16.2.12.

next 16.3.0 clears all four:

  GHSA-r28c-9q8g-f849  postcss  path traversal via previous-source-map loading
  GHSA-6g55-p6wh-862q  postcss  arbitrary file read via sourceMappingURL
  GHSA-qx2v-qp2m-jg93  postcss  XSS via unescaped </style> in stringify
  GHSA-f88m-g3jw-g9cj  sharp    inherited libvips CVEs (< 0.35.0)

npm audit: 7 vulnerabilities (6 high) -> 4 (3 high). sharp 0.34.5 -> 0.35.3, and
the nested postcss is now 8.5.23, past every advisory's patched version.

The upgrade brings stricter bundled typings, which broke the build with 27
TypeScript errors — all in src/__tests__, none in production source. Fixed
rather than silenced; no `as any` was added anywhere (two existing ones were
narrowed to `as never`), and all 1276 tests still pass:

- reviewApi.getFileDiff does not exist. The test mocked and stubbed a method
  that is not on the API; the `as jest.Mock` cast hid it. Removed — dead setup,
  and its 13 tests still pass.
- ProofRequirement.scope became a required (nullable) field with the #568 scope
  work; five fixtures predated it and now supply it.
- TaskBoardView called .mockResolvedValue on the real typed tasksApi. Now uses
  jest.mocked(), which keeps the real signatures — so the toHaveBeenCalledWith
  assertions still type-check against true argument shapes. That immediately
  caught two more: updateStatus.mockResolvedValue({}) where a Task is required,
  now using the file's own makeTask factory.
- Blocker.created_by is required; the fixture omitted it.
- The WebSocket mock declared onclose as taking no arguments while calling it
  with a CloseEvent, and passed Uint8Array.buffer (ArrayBufferLike, possibly a
  SharedArrayBuffer) where a real binary message carries an ArrayBuffer.
- Two @ts-expect-error directives are now unused because axios types `handlers`;
  removed, with the reason kept as a comment.
- axios.isAxiosError was being reassigned, which fights jest.Mocked's
  intersection type; drives the existing auto-mock instead.
- The remaining partial mocks of SWRResponse / AppRouterInstance assert through
  `unknown`, which keeps the target type rather than erasing it.

#1123 is already merged and is harmless but unrelated. The four remaining
advisories (all dev/build-time) and raising deploy.yml's --audit-level above
critical are coupled and tracked in #1131 — raising the gate today would block
every deploy on findings nothing has decided about yet.

* style(web-ui): address review nits — import ordering and fixture formatting (#1124)

Both non-blocking, both worth taking: the jest.mocked() binding sat between two
import statements (valid, but an import/first rule would flag it), and scope:
null was appended to the related_reqs line rather than getting its own, which
did not match the surrounding fixture style.

No behaviour change: tsc clean, eslint clean, 108 tests in the touched suites
still pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant