fix(thin): implement missing Validate logic for ReferenceDatasetEngine#5998
fix(thin): implement missing Validate logic for ReferenceDatasetEngine#5998Sukuna0007Abhi wants to merge 2 commits into
Conversation
Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
|
Hi @Sukuna0007Abhi. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements validation logic for the ReferenceDatasetEngine by calling checkDatasetMountSupport in the Validate method. However, a correctness issue was identified where validation is bypassed during creation and uses stale data during updates because the dataset is fetched from the API server/cache instead of the reconciliation context. It is recommended to refactor the validation to use the dataset object provided in the context.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…ass on creation Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
|
|
Plz review @cheyang @TrafalgarZZZ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5998 +/- ##
==========================================
- Coverage 63.56% 63.56% -0.01%
==========================================
Files 479 479
Lines 33276 33280 +4
==========================================
+ Hits 21151 21153 +2
- Misses 10445 10447 +2
Partials 1680 1680 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cheyang
left a comment
cheyang
left a comment
There was a problem hiding this comment.
All CI checks passed and maintainer has approved. Auto-approving to satisfy branch protection.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Ⅰ. Describe what this PR does
This PR implements the missing
Validatelogic for theReferenceDatasetEngine. Instead of immediately returningnil, it now retrieves the dataset and delegates validation to thecheckDatasetMountSupportfunction. This ensures that any unsupported dataset mounts are caught early during the validation phase.Ⅱ. Does this pull request fix one or more issues?
fixes #5997
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
No new tests were required; existing validation test flows will cover the integrated
checkDatasetMountSupportlogic.Ⅳ. Describe how to verify it
Create a
ReferenceDatasetwith an invalid or unsupported mount format. Ensure that the validation webhook/controller correctly rejects it during creation rather than failing silently.Ⅴ. Special notes for reviews
None.