fix: support serverless logs and robust timeout in diagnose scripts#5671
fix: support serverless logs and robust timeout in diagnose scripts#5671Ayush-Patel-56 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Ayush-Patel-56. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary of ChangesHello @Ayush-Patel-56, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the diagnostic scripts for Fluid runtimes by introducing support for collecting logs from serverless-enabled pods and improving the robustness of command timeouts. These changes ensure that diagnostic information can be gathered more comprehensively across different deployment environments and operating systems, particularly macOS, by providing alternative timeout mechanisms. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
6c34476 to
ddcaab1
Compare
There was a problem hiding this comment.
Code Review
This pull request enhances the diagnostic scripts by adding support for serverless logs and improving timeout handling, particularly for macOS compatibility. The changes involve modifying the run function to use gtimeout or perl as fallbacks for timeout, adding a serverless_pod_logs function to collect logs from serverless pods, and incorporating this function into the pd_collect function in multiple shell scripts. Additionally, a typo in the GooseFS script has been fixed.
629c979 to
abc4725
Compare
|
There was a problem hiding this comment.
Pull request overview
This PR updates the runtime-specific diagnostic shell scripts to better support serverless (sidecar-injected) workloads and improve compatibility on macOS systems that lack GNU timeout.
Changes:
- Adds a
run()helper fallback chain (timeout→gtimeout→perlalarm/exec) to avoid failures when GNUtimeoutis missing. - Adds serverless pod fuse-sidecar log collection for pods labeled
serverless.fluid.io/inject=true. - Fixes a namespace variable typo/bug in the GooseFS diagnose script.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| tools/diagnose-fluid-juicefs.sh | Adds timeout fallback and serverless fuse-sidecar log collection. |
| tools/diagnose-fluid-jindo.sh | Adds timeout fallback and serverless fuse-sidecar log collection. |
| tools/diagnose-fluid-goosefs.sh | Adds timeout fallback, serverless fuse-sidecar log collection, and fixes namespace comparison typo. |
| tools/diagnose-fluid-alluxio.sh | Adds timeout fallback and serverless fuse-sidecar log collection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abc4725 to
173ef19
Compare
Signed-off-by: Ayush Patel <ayushpatel2731@gmail.com>
173ef19 to
9bcd964
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5671 +/- ##
=======================================
Coverage 63.56% 63.56%
=======================================
Files 479 479
Lines 33276 33276
=======================================
Hits 21151 21151
Misses 10445 10445
Partials 1680 1680 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@cheyang @TrafalgarZZZ @RongGu requesting a friendly bump |



Ⅰ. Describe what this PR does
Updates diagnostic scripts across all runtimes to support serverless mode and improve macOS compatibility.
Changes:
serverless.fluid.io/inject=true.gtimeoutorperlas a fallback when GNUtimeoutis missing.fluid_namesapce) in the GooseFS script.Ⅱ. Does this pull request fix one issue?
fixes #1852
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Manual verification of the timeout logic on systems without GNU coreutils. No tests needed for these standalone shell utilities.
Ⅳ. Describe how to verify it
perlfallback instead of failing withcommand not found.Ⅴ. Special notes for reviews
Used a
perlone-liner for the timeout fallback to keep the scripts dependency-free.