decode_opentelemetry: bound wire decoding and attribute nesting - #97
Merged
Merged
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
marked this pull request as ready for review
September 19, 2026 13:27
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject excessively nested OTLP attributes and wire messages before they can exhaust decoder resources or produce contexts beyond the MessagePack nesting budget.
A schema-aware wire preflight now runs before recursive protobuf-c unpacking, so the protection also covers allocation and recursive cleanup before CFL conversion. It uses an explicit stack with a 100-message budget and treats strings, bytes, packed scalars and unknown fields as opaque. Attribute conversion separately retains the 32-container limit, with the outer attribute map at depth zero. Public helper signatures remain unchanged.
Validation: all 6 CTest targets pass. The protobuf boundary and OTLP tests pass Valgrind with zero errors and no leaks. Downstream Fluent Bit Forward/OTLP regression tests pass normally and under strict Valgrind. Tests cover 99/100/101 schema-message boundaries, malformed wire lengths/varints, and existing 8/31/32/400 attribute-depth cases across maps, arrays and mixed nesting.
Compatibility: excessive nesting is rejected. The protobuf budget counts intermediate protocol wrappers as well as AnyValue messages; existing supported attribute-depth tests still pass. No public ABI changes.