#44954 API design: Custom host vitals#48369
Draft
rachaelshaw wants to merge 6 commits into
Draft
Conversation
fleet-release
approved these changes
Jun 26, 2026
56 tasks
5 tasks
nulmete
reviewed
Jul 1, 2026
nulmete
left a comment
Member
There was a problem hiding this comment.
Let me know what you think about my suggestions below.
Also, in order to list the custom host vitals for a particular host, I suggest extending the current host details endpoint (GET api/latest/fleet/hosts/:hostId) with a new custom_host_vitals property. (Implementation detail, no need to include a change here I think.)
Comment on lines
+15078
to
+15080
| ### Update host's custom host vital value | ||
|
|
||
| > TODO |
Member
There was a problem hiding this comment.
This should probably be
PUT /hosts/:host_id/custom_host_vitals/:id
Body:
{
"value": "ABC-1234"
}
Default response:
Status: 200
{
"host_id": 42,
"custom_host_vital_id": 123,
"name": "Asset tag",
"value": "ABC-1234",
"updated_at": "2026-07-01T15:23:57Z"
}
3 tasks
nulmete
reviewed
Jul 3, 2026
Co-authored-by: Nico <32375741+nulmete@users.noreply.github.com>
fleet-release
approved these changes
Jul 3, 2026
rachaelshaw
commented
Jul 3, 2026
fleet-release
approved these changes
Jul 3, 2026
Co-authored-by: Nico <32375741+nulmete@users.noreply.github.com>
fleet-release
approved these changes
Jul 3, 2026
fleet-release
approved these changes
Jul 3, 2026
nulmete
approved these changes
Jul 6, 2026
lucasmrod
reviewed
Jul 6, 2026
|
|
||
| | Name | Type | In | Description | | ||
| |:--------------- |:------- |:----- |:------------------------------------------------------------| | ||
| | name | string | body | **Required.** The desired variable name, without the `FLEET_SECRET_` prefix. | |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| | name | string | body | **Required.** The desired variable name, without the `FLEET_SECRET_` prefix. | | |
| | name | string | body | **Required.** The desired variable name, without the `FLEET_HOST_VITAL_` prefix. | |
lucasmrod
reviewed
Jul 6, 2026
|
|
||
| Update the value of a custom host vital for a single host. | ||
|
|
||
| `PUT /hosts/:host_id/custom_host_vitals/:id` |
Member
There was a problem hiding this comment.
"Clearing" a host's custom vital is about PUTing with "value": "", right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still TODO: "Update host's custom host vital value" endpoint