Release QA template: progress checkboxes, drop pass/fail column, update loadtesting instructions#48312
Merged
Merged
Conversation
Match the Release QA - fleetd template format: - Add a "How to check off" note - Add per-section Progress checkbox lists - Drop the pass/fail column and the $Name placeholder row - Split Load tests into Baseline loadtest and Migration loadtest
AndreyKizimenko
had a problem deploying
to
Docker Hub
GitHub Actions
Error
Replace the old Google-doc loadtest steps with the collect-metrics.sh / compare-metrics.sh workflow: - Baseline: collect under the baseline category, compare against n-1, post the comparison as an issue comment, then PR the run artifacts. - Migration: collect the last 2h on n-1 pre-migration, migrate to the RC, wait ~2h, collect the past 2h, compare before vs. after, PR the artifacts. Both steps link the collect/compare scripts and record results in the sheet.
AndreyKizimenko
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
AndreyKizimenko
requested review from
Brajim20,
chrstphr84,
lukeheath and
xpkoala
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
AndreyKizimenko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: N/A — internal release-QA issue template update
Description
Updates the Release QA issue template (
.github/ISSUE_TEMPLATE/release-qa.md) to match the format already used by the Release QA - fleetd template:$Nameplaceholder example row.tools/loadtest/metrics/tooling (see below).No code or product behavior changes — issue template only.
New load test flow
Both load tests now use the
tools/loadtest/metrics/scripts —collect-metrics.sh(pulls CloudWatch metrics into a.jsondata file +.mdsynopsis) andcompare-metrics.sh(diffs two runs and flags deltasok/WARN/ALERT). Condition of satisfaction for each: collect → compare → post the comparison as an issue comment → open a PR with the run artifacts and record results in the metrics spreadsheet.Baseline loadtest (compared against the previous release, n-1):
baselinecategory.ok..json+.md) underruns/baseline/<workspace>/and record metrics in the spreadsheet.Migration loadtest (compared before vs. after the migration):
ok.runs/migration/<workspace>/and record metrics in the spreadsheet.Example result PRs this flow produces: #47794 (baseline), #47803 (migration).
Checklist for submitter