Skip to content

Add Easy-commit #571

Open
KirobotDev wants to merge 1 commit into
firstcontributions:mainfrom
KirobotDev:main
Open

Add Easy-commit #571
KirobotDev wants to merge 1 commit into
firstcontributions:mainfrom
KirobotDev:main

Conversation

@KirobotDev

Copy link
Copy Markdown

No description provided.

@KirobotDev KirobotDev changed the title Update ProjectCard.astro Add Easy-commit Mar 15, 2026
@Sean-Kenneth-Doherty

Copy link
Copy Markdown

I tested this locally. The build passes, and moving the actual project link onto the “Go to Project” control is the right general direction for the nested-anchor bug, but this patch is not complete yet.

Checks run:

  • git diff --check main...HEAD passes
  • pnpm build passes

Blocker: src/components/ProjectList.astro still builds its client-side projectList data with card.querySelector('.Card-Real-Link'). This PR removes .Card-Real-Link from ProjectCard.astro, so the script will set projectLink: link?.href || '' to an empty string for every card. That can break the filtered/search-rendered card links even though the static HTML build succeeds.

Also, the PR title/body say “Add Easy-commit”, but this branch changes ProjectCard.astro and does not add a project. I would retitle it around the nested-anchor / Go to Project fix so reviewers know what behavior to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants