You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tested this locally. The build passes, and moving the actual project link onto the “Go to Project” control is the right general direction for the nested-anchor bug, but this patch is not complete yet.
Checks run:
git diff --check main...HEAD passes
pnpm build passes
Blocker: src/components/ProjectList.astro still builds its client-side projectList data with card.querySelector('.Card-Real-Link'). This PR removes .Card-Real-Link from ProjectCard.astro, so the script will set projectLink: link?.href || '' to an empty string for every card. That can break the filtered/search-rendered card links even though the static HTML build succeeds.
Also, the PR title/body say “Add Easy-commit”, but this branch changes ProjectCard.astro and does not add a project. I would retitle it around the nested-anchor / Go to Project fix so reviewers know what behavior to test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.