fix: decode ECN codepoint 0b11 as CongestionExperienced - #1
Closed
thomaseizinger wants to merge 4 commits into
Closed
fix: decode ECN codepoint 0b11 as CongestionExperienced#1thomaseizinger wants to merge 4 commits into
thomaseizinger wants to merge 4 commits into
Conversation
thomaseizinger
force-pushed
the
claude/ip-packet-ingot-refactor-3wzbin
branch
2 times, most recently
from
July 17, 2026 04:44
cebbfb2 to
be8cca2
Compare
The most recent `darling` release required a compiler bump, so we move up to 1.97.1 (i.e., the first rustc in a while that darling supports without a latent miscompilation bug). A new `syn` is a available, but this looks to have a pile of breasking changes to consider.
`Ecn::from_network` and `Ecn::try_from` both mapped the wire value 3 (CE, "Congestion Experienced") to `Ecn::Capable0`, silently collapsing the CE marking into ECT(1) on the next serialisation and dropping the congestion signal. Decode it to the existing `Ecn::CongestionExperienced` variant instead so all four RFC 3168 codepoints round-trip.
thomaseizinger
force-pushed
the
claude/ip-packet-ingot-refactor-3wzbin
branch
from
July 24, 2026 22:36
be8cca2 to
e63b00f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Ecndecoders folded the CE (Congestion Experienced,0b11) codepoint intoCapable0, so a CE-marked packet re-serialised as ECT(1) and the congestion signal was lost. Decoding it to the existingCongestionExperiencedvariant makes all four RFC 3168 codepoints round-trip.This lets downstream consumers (Firezone's
ip-packet) rely on the typedEcnfield instead of reading the ECN bits raw.Generated by Claude Code