build: push specific docker image version tags during Cloud Build step#10748
Merged
Conversation
avolkovi
force-pushed
the
fix-docker-publish-tags
branch
from
38558eb to
8b39bb7
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Cloud Build configuration files to extract the version number into a local variable and adds explicit docker push commands for the built images. The reviewer feedback suggests adding 'set -e' to ensure the build fails fast if docker build fails, and refactoring the long single-line command in the firebase-docker-image cloudbuild.yaml into a multi-line block literal for better readability and maintenance.
avolkovi
force-pushed
the
fix-docker-publish-tags
branch
from
8b39bb7 to
03d70c1
Compare
# Conflicts: # scripts/publish/firebase-docker-image/cloudbuild.yaml
joehan
approved these changes
Jun 30, 2026
joehan
left a comment
joehan
left a comment
Member
There was a problem hiding this comment.
Code looks fine, tho i am confused why we need this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands