Add release workflow - #2940
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
Isn't zizmor going to come through and say this must be a SHA and be right?
There was a problem hiding this comment.
Yeah, this is still a draft because I'm working through stuff. Trying to figure out what I need to do to get this to show up in the actions dashboard for e.g.
| DRY_RUN="${{ inputs.dry_run }}" | ||
|
|
||
| if [ "$DRY_RUN" = "true" ]; then | ||
| npm version $BUMP_TYPE --preid=rc --no-git-tag-version |
There was a problem hiding this comment.
Do I understand correctly that this still updates the version locally just doesn't commit it via git. Should we do even this much or revert it later?
There was a problem hiding this comment.
We do this because npm publish has a dry run as well which verifies auth and other requirements and will be driven by this.
There was a problem hiding this comment.
Ok. I guess it gets cleaned up at some point? Could be worth a comment since it's an interesting semi real thing happening during dry run.
| required: true | ||
| type: choice | ||
| options: | ||
| - "kits/bigquery-firestore-export" |
There was a problem hiding this comment.
We should coordinate with @cabljac and Invertase. If we move definitive location for some of these kits back to the google cloud extensions repo to be next to the Extension implementations we'll need a similar workflow there.
There was a problem hiding this comment.
Yeah, there's some stuff we can play with like making the branch configurable or making this not prefill. Easy changes that don't block getting started testing this though IMO.
inlined
left a comment
inlined
left a comment
There was a problem hiding this comment.
Sorry this stayed in draft a while. I had one branch for multiple changes because Gemini lied to me and said I could try to run the action from a branch. Now I'm not entirely sure that's true and I'm trying to split changes across different branches with different base targets which is reasonably annoying.
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
Yeah, this is still a draft because I'm working through stuff. Trying to figure out what I need to do to get this to show up in the actions dashboard for e.g.
| DRY_RUN="${{ inputs.dry_run }}" | ||
|
|
||
| if [ "$DRY_RUN" = "true" ]; then | ||
| npm version $BUMP_TYPE --preid=rc --no-git-tag-version |
There was a problem hiding this comment.
We do this because npm publish has a dry run as well which verifies auth and other requirements and will be driven by this.
| required: true | ||
| type: choice | ||
| options: | ||
| - "kits/bigquery-firestore-export" |
There was a problem hiding this comment.
Yeah, there's some stuff we can play with like making the branch configurable or making this not prefill. Easy changes that don't block getting started testing this though IMO.
3 participants
I think this has to be in main for it to actually be accessible to run. So much for testing before reviewing =/