Detect external links by host instead of url prefix#4
Open
julioalucero wants to merge 1 commit into
Open
Conversation
julioalucero
force-pushed
the
FR-740-fix-nofollow-internal-links
branch
from
1460bad to
a380c1b
Compare
julioalucero
force-pushed
the
FR-740-fix-nofollow-internal-links
branch
from
a380c1b to
7486849
Compare
arielj
reviewed
Jul 1, 2026
| next if a['href'].nil? || a['href'].empty? || a['href'].start_with?('#') || a['data-no-external'] == 'true' | ||
|
|
||
| if a['href'].start_with?('http') || a['href'].start_with?('/') | ||
| if external_link?(a['href'], site_host) |
There was a problem hiding this comment.
I think we still want to open internal links in new tabs but without the nofollow.
Like.. you are reading an article, you click an internal link and it opens a new tab, so you are not taken away from the place you were reading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira
FR-740: Fix nofollow on internal links
PR description
Internal links (
/blog/...and absolute links to our own domain) were gettingnofollow, target="_blank"and the external-link icon because the old check treated anything starting withhttpor/as external.What we did here:
urlfrom_config.yml, only flag links to a different host as external.www.prefix and host casing when comparing.//host/...) as external too.QA steps
/blog/something, should be internal.