Remove spring and spring-watcher-listen (dev preloader)#89
Merged
Conversation
spring is optional developer tooling (an app preloader), not required at Rails 8.1 — modern Rails no longer ships it in the default Gemfile. It's a direct-only dependency here (nothing pulls it transitively), and in practice it's been a source of stale-state/hang gotchas (commands had to be run with DISABLE_SPRING=1). Dropping it simplifies the dev setup with no runtime impact. - Gemfile: remove gem "spring" + gem "spring-watcher-listen" (and the pin comment) - bin/rails, bin/rake: drop the spring loader preamble (standard binstubs) - delete bin/spring and config/spring.rb - both lockfiles updated Verified locally: bin/rails runner + bin/rake work without the preamble, test suite 16/52/0 (run via the binstubs), rubocop + reek clean.
1cf3864 to
2bb8d15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
springapp preloader and itsspring-watcher-listenplugin.Why
springis optional developer tooling (a Rails application preloader) — not required at Rails 8.1, and no longer shipped in modern Rails' default Gemfile. Here it's a direct-only dependency (nothing pulls it transitively), and in practice it's been a source of stale-state / hang gotchas (one-shot commands had to be run withDISABLE_SPRING=1). Dropping it simplifies the dev setup with no runtime impact — spring never runs in production.Changes
Gemfile: removegem "spring"andgem "spring-watcher-listen"(and the now-moot pin comment)bin/rails,bin/rake: drop the spring loader preamble → plain standard binstubsbin/springandconfig/spring.rbGemfile.lock+ dual-bootGemfile.next.lockupdatedVerification
bin/rails runnerandbin/rake --taskswork with the preamble removed (no spring needed)rubocopclean (exact CI config),reekcleanNo production/runtime surface — spring is development-group only.