Remove unused font-awesome-rails#88
Merged
Merged
Conversation
font-awesome-rails was pulled in solely by a bare `@import "font-awesome"` in pdf.scss, but no icon is ever rendered: no fa- classes, no fa_icon, no FA glyphs in any view or stylesheet. It imported the entire Font Awesome CSS plus its webfonts (fontawesome-webfont.woff/ttf/svg) into the PDF bundle for zero visible benefit. The fastruby-styleguide gem does not use it either (it uses Material Icons); font-awesome-rails is a direct-only dependency. Dropped the gem and the pdf.scss import; both lockfiles updated. Verified locally: assets:precompile compiles pdf.css with no fontawesome webfonts emitted, unit tests 16/52/0, rubocop + reek clean, and the system test (upload -> results -> PDF download) passes in headless Chrome — the PDF still renders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the unused
font-awesome-railsgem.Why
font-awesome-railswas pulled in solely by a bare@import "font-awesome"inapp/assets/stylesheets/pdf.scss, but no icon is ever rendered: there are nofa-classes, nofa_iconhelpers, and no Font Awesome glyphs anywhere in the views or stylesheets. It imported the entire Font Awesome CSS plus its webfonts (fontawesome-webfont.woff/ttf/svg) into the PDF asset bundle for zero visible benefit.The
fastruby-styleguidegem does not depend on it (the styleguide uses Material Icons + Bootstrap, self-contained).font-awesome-railsis a direct-only dependency — nothing pulls it transitively.Changes
Gemfile: removegem "font-awesome-rails"pdf.scss: remove the@import "font-awesome"line (and its stale section comment)Gemfile.lock+ dual-bootGemfile.next.lockupdatedVerification
assets:precompilecompilespdf.csscleanly and nofontawesome-webfontassets are emitted anymorerubocopclean (exact CI config),reekclean