Remove unused jbuilder gem#79
Merged
Merged
Conversation
jbuilder was dead weight: no .jbuilder templates, no json. rendering, no format.json anywhere in the app (it renders HTML + PDF only). Dropped the gem line; both Gemfile.lock and the dual-boot Gemfile.next.lock updated. Verified: app boots and the full test suite passes (16 runs, 52 assertions, 0 failures) with the gem removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the unused
jbuildergem.Why
jbuilderis dead weight in this app: it renders HTML and PDF only, with no JSON endpoints. A root-usage pass found:.jbuildertemplates anywherejson.rendering in any viewformat.json/render json:in any controllerNothing in the app exercises the gem, so it is safe to drop.
Changes
gem "jbuilder", "~> 2.5"from theGemfileGemfile.lockand the dual-bootGemfile.next.lockaccordinglyVerification