Skip to content

CI Cache Enhancements#88

Merged
posborne merged 3 commits into
mainfrom
posborne/ci-enhancements
Apr 13, 2026
Merged

CI Cache Enhancements#88
posborne merged 3 commits into
mainfrom
posborne/ci-enhancements

Conversation

@posborne
Copy link
Copy Markdown
Member

@posborne posborne commented Apr 13, 2026

CI had failed in the most recent set of changes which touched Cargo.lock (invalidating cache). Things were timing out in clippy. This change gets CI passing again by implementing a few improvements:

  • Avoid running CI on branch push (can still trigger manually in GH)
  • Caching of sources was separated from binary caches.
  • Sccache was using a deprecated node version and not giving us anything, removed.
  • For clippy, we match the flags from our maturin compile stage which let's us avoid another rebuild. This makes sense for now; if it stops making sense then we could move clippy to do its build in parallel with everything else and that might solve our problem in another way (though what we cache becomes messier, so this seems preferable).
  • Include the RUSTUP_TOOLCHAIN version in the cache key. If our toolchain version changes, we need new binaries and this helps avoid bloat (source isn't impacted by this).

Running ci on push to any branch was unintentional and puts more
load on CI.  Creating a PR or doing a workflow_dispatch request
seems like it should cover things well enough for now and avoid
too many long-running jobs.
This is just more consistent; it does tie some specifics
that are required by CI with the makefile, but I think
that's probably fine and it's preferable to have what
clippy does locally and in ci match.
@posborne posborne requested a review from erikrose April 13, 2026 19:16
@posborne posborne merged commit 4dc00ba into main Apr 13, 2026
3 checks passed
@posborne posborne deleted the posborne/ci-enhancements branch April 13, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants