Preserve optional chains in exhaustive-deps suggestions#36411
Open
raashish1601 wants to merge 1 commit into
Open
Preserve optional chains in exhaustive-deps suggestions#36411raashish1601 wants to merge 1 commit into
raashish1601 wants to merge 1 commit into
Conversation
codeCraft-Ritik
left a comment
codeCraft-Ritik
left a comment
There was a problem hiding this comment.
Nice fix! Preserving the optional form in exhaustive-deps suggestions avoids introducing unsafe render-time behavior while resolving dependency warnings.
Good catch on the dependency array semantics outside guarded execution paths 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23248.
When the same dependency path is read through both optional and non-optional member expressions, the exhaustive-deps suggestion should keep the optional form. Dependency arrays are evaluated outside guarded blocks, so suggesting the non-optional form can introduce a render-time error while fixing an unrelated dependency.
Tests
corepack yarn --cwd packages/eslint-plugin-react-hooks jest ESLintRuleExhaustiveDeps-test --runInBandcorepack yarn --cwd packages/eslint-plugin-react-hooks typecheckgit diff --check