ArrayBuffer support to C++ TurboModules#56729
Open
paradowstack wants to merge 10 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Callstack
paradowstack
force-pushed
the
feat/array-buffers
branch
from
b568fbe to
8a8b192
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
ArrayBuffersupport to C++ TurboModules. This includes:ArrayBufferTypeAnnotationin module specsAsyncArrayBuffer— a move-only bridging type for holding ArrayBuffer data off the JS threadBridging<AsyncArrayBuffer>::toJsfor resolving promises with native-backed or owned-bytes buffersiOS and Android support will follow in separate PRs. The new codegen type is currently restricted to C++ TurboModules via
excludedPlatforms: ['iOS', 'android'].Changelog:
[GENERAL] [ADDED] - Add
ArrayBuffersupport to C++ TurboModulesTest Plan:
BridgingTest.cppcoverAsyncArrayBufferconstruction and JS bridging.rn-tester:getArrayBuffer,processAsyncBuffer, andgetAsyncBuffermethods added toNativeCxxModuleExamplein demo app.