Add TextEffect component and registry for custom text span effects (#56720)#56720
Closed
andrewdacenko wants to merge 1 commit into
Closed
Add TextEffect component and registry for custom text span effects (#56720)#56720andrewdacenko wants to merge 1 commit into
andrewdacenko wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@andrewdacenko has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98812222. |
…acebook#56720) Summary: Introduces a generic TextEffect system that lets apps register custom text span effects without modifying React Native core. This can serve for use cases like `react-native-live-markdown`, or product specific effects. The implementation is pretty dumb right now. It's just a marker, where we can add some JSON serializable data, to be serialized during Spannable creation on JS side MapBuffer. **JS API:** ```js import requireNativeTextEffect from 'react-native/Libraries/Text/requireNativeTextEffect'; const Spoiler = requireNativeTextEffect<{}>('RCTSpoiler'); <Text>Normal <Spoiler>hidden text</Spoiler></Text> ``` **Android registration** (via FabricUIManager): ```kotlin val fabricUIManager = UIManagerHelper.getUIManager( context, UIManagerType.FABRIC) as? FabricUIManager fabricUIManager?.textEffectRegistry?.register("RCTSpoiler") { props -> MyCustomSpan() } ``` Changelog: [Internal] Reviewed By: javache Differential Revision: D98812222
meta-codesync
Bot
changed the title
andrewdacenko
force-pushed
the
export-D98812222
branch
from
107a441 to
b4c9778
Compare
|
This pull request has been merged in ab8b40d. |
Collaborator
|
This pull request was successfully merged by @andrewdacenko in ab8b40d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces a generic TextEffect system that lets apps register custom text
span effects without modifying React Native core. This can serve for use cases like
react-native-live-markdown, or product specific effects.The implementation is pretty dumb right now. It's just a marker, where we can add some JSON serializable data, to be serialized during Spannable creation on JS side MapBuffer.
JS API:
Android registration (via FabricUIManager):
Changelog: [Internal]
Reviewed By: javache
Differential Revision: D98812222