Skip to content

docs & HSL: update HackC frontend refs to Rust and expand unit test coverage - #9828

Open
omen18 wants to merge 1 commit into
facebook:masterfrom
omen18:contribute-hsl-docs
Open

docs & HSL: update HackC frontend refs to Rust and expand unit test coverage#9828
omen18 wants to merge 1 commit into
facebook:masterfrom
omen18:contribute-hsl-docs

Conversation

@omen18

@omen18 omen18 commented Aug 8, 2026

Copy link
Copy Markdown

Description

This PR contributes documentation updates, configuration spec fixes, and 550+ lines of new unit test coverage across the Hack Standard Library (HSL).

1. Developer Documentation & Config

  • Updated hphp/doc/hackers-guide/README.md and hphp/doc/hackers-guide/glossary.md to state that the Hack Compiler frontend (hackc) and bytecode emitter are written in Rust (updating obsolete references to OCaml).
  • Corrected grammar and phrasing in hphp/doc/ini.md for wildcard configuration setting symlinking and copying.

2. Hack Standard Library (HSL) Test Coverage

  • Math: Created MathExtendedSuiteTest.php and updated MathCompareTest.php with tests for trigonometric identities, exponential/logarithmic inverse pairs, base conversions, rounding modes, integer division exceptions, and float comparison edge cases.
  • Str: Created StrExtendedSuiteTest.php and updated StrIntrospectTest.php with tests for chunking, trimming, padding, case folding (uppercase, lowercase, capitalize), multibyte emoji prefixes, splitting/joining, and string replacement.
  • Vec: Created VecExtendedSuiteTest.php and updated VecSelectTest.php with tests for concat, fill, filter, map, reverse, sort, zip, and range.
  • Keyset & Dict: Added test tuples to KeysetIntrospectTest.php and DictIntrospectTest.php for empty keysets/dicts, string key mappings, and null value handling.
  • Regex: Added pattern string representation tests to RegexTest.php.

@meta-cla

meta-cla Bot commented Aug 8, 2026

Copy link
Copy Markdown

Hi @omen18!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@omen18

omen18 commented Aug 10, 2026

Copy link
Copy Markdown
Author

@meta-cla check

@meta-cla meta-cla Bot added the CLA Signed label Aug 10, 2026
@meta-cla

meta-cla Bot commented Aug 10, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant