docs & HSL: update HackC frontend refs to Rust and expand unit test coverage - #9828
docs & HSL: update HackC frontend refs to Rust and expand unit test coverage#9828omen18 wants to merge 1 commit into
Conversation
|
Hi @omen18! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@meta-cla check |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Description
This PR contributes documentation updates, configuration spec fixes, and 550+ lines of new unit test coverage across the Hack Standard Library (HSL).
1. Developer Documentation & Config
hphp/doc/hackers-guide/README.mdandhphp/doc/hackers-guide/glossary.mdto state that the Hack Compiler frontend (hackc) and bytecode emitter are written in Rust (updating obsolete references to OCaml).hphp/doc/ini.mdfor wildcard configuration setting symlinking and copying.2. Hack Standard Library (HSL) Test Coverage
MathExtendedSuiteTest.phpand updatedMathCompareTest.phpwith tests for trigonometric identities, exponential/logarithmic inverse pairs, base conversions, rounding modes, integer division exceptions, and float comparison edge cases.StrExtendedSuiteTest.phpand updatedStrIntrospectTest.phpwith tests for chunking, trimming, padding, case folding (uppercase,lowercase,capitalize), multibyte emoji prefixes, splitting/joining, and string replacement.VecExtendedSuiteTest.phpand updatedVecSelectTest.phpwith tests forconcat,fill,filter,map,reverse,sort,zip, andrange.KeysetIntrospectTest.phpandDictIntrospectTest.phpfor empty keysets/dicts, string key mappings, and null value handling.RegexTest.php.