Skip to content

fix: detect secure socket when connection is missing#1124

Open
raashish1601 wants to merge 1 commit into
expressjs:masterfrom
raashish1601:fix/socket-secure-detection
Open

fix: detect secure socket when connection is missing#1124
raashish1601 wants to merge 1 commit into
expressjs:masterfrom
raashish1601:fix/socket-secure-detection

Conversation

@raashish1601
Copy link
Copy Markdown

Changes

  • Update secure-request detection to fall back to req.socket.encrypted when req.connection is missing.
  • Preserve existing req.connection precedence while supporting environments where only req.socket is available.
  • Add regression test under session() cookie security behavior: treat request as secure when connection is missing but socket.encrypted is true.

Validation

  • npm run lint
  • npx mocha --require test/support/env --check-leaks --no-exit --reporter spec test/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant