Repository navigation
Stop false missing-translation reports in Sentry - #13011
Merged
Merged
Conversation
Proxies such as Google Translate serve copies of our pages from their own hosts, where the locale catalog often fails to load. Every key on the page then looks missing and floods Sentry. In production, missing keys are now only reported when the page is served from exercism.org. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
If a locale's catalog fails to load, every key on the page looks missing, so one failed fetch can create dozens of Sentry issues for keys that are translated. Missing keys in a non-English locale are now only reported once that locale's catalog has loaded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two situations make every key on a page look missing, and each one floods Sentry with "Missing translation" issues for keys that are translated.
*.translate.goog) serves copies of our pages from its own host, where the locale catalog often fails to load. One visit to a proxied pt-BR exercises page created 12 issues. In production, missing keys are now only reported when the page is served fromexercism.org.loadCatalogcatches the error, the language still switches, and every key is reported.beforeSenddrops the fetch error itself as a network error, so only the noise reaches Sentry. One crawler visit to the zh-CN profile and contributors pages created about 65 issues, and every key involved is in the zh-CN catalog. Missing keys in a non-English locale are now only reported once that locale's catalog has loaded.Real gaps will still be reported. In a locale whose catalog loaded on exercism.org, a missing key creates an issue as before.
Both cases have tests in
test/javascript/i18n/i18n.test.ts.🤖 Generated with Claude Code