Repository navigation
Refactor to broadly use local vars - #2900
Open
yorickdowne wants to merge 2 commits into
Open
yorickdowne wants to merge 2 commits into
yorickdowne wants to merge 2 commits into
Conversation
yorickdowne
added
check-ethd
check-ethd-macos
yorickdowne
force-pushed
the
chore/more-locals
branch
3 times, most recently
from
October 6, 2026 06:33
3c61c3b to
b00550e
Compare
yorickdowne
added
check-ethd-macos
yorickdowne
force-pushed
the
chore/more-locals
branch
from
October 6, 2026 14:47
b00550e to
36c1edc
Compare
yorickdowne
removed
the
check-ethd-macos
Collaborator
Author
|
macOS check keeps timing out while installing homebrow pre-reqs. The days of checking ethd on macOS may be over |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
__get_value_from_envcan write into local variables because of bash dynamic scopingAdjust
ethdcode to use locals much more broadly.Where globals pass values between functions or are used to write into
.env, they are kept.Document when to use globals