Skip to content

chore(specs): add type alias for fee market txs#2968

Merged
SamWilsn merged 1 commit into
ethereum:forks/amsterdamfrom
SamWilsn:fee-market-capable
Jun 15, 2026
Merged

chore(specs): add type alias for fee market txs#2968
SamWilsn merged 1 commit into
ethereum:forks/amsterdamfrom
SamWilsn:fee-market-capable

Conversation

@SamWilsn

@SamWilsn SamWilsn commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🗒️ Description

Factor out a type alias for transactions with fee market-style fields.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@SamWilsn SamWilsn requested a review from gurukamath June 9, 2026 15:28
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.53%. Comparing base (21ecd8f) to head (032bd27).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2968   +/-   ##
================================================
  Coverage            90.53%   90.53%           
================================================
  Files                  535      535           
  Lines                32897    32905    +8     
  Branches              3021     3021           
================================================
+ Hits                 29782    29790    +8     
  Misses                2596     2596           
  Partials               519      519           
Flag Coverage Δ
unittests 90.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SamWilsn SamWilsn force-pushed the fee-market-capable branch from 86c384d to da8178b Compare June 9, 2026 17:23
@SamWilsn SamWilsn force-pushed the fee-market-capable branch from da8178b to 032bd27 Compare June 9, 2026 17:28

@LouisTsai-Csie LouisTsai-Csie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@SamWilsn SamWilsn merged commit 54246cd into ethereum:forks/amsterdam Jun 15, 2026
26 checks passed
@SamWilsn SamWilsn deleted the fee-market-capable branch June 15, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants