Implement SFX for void enemy - #2862
Open
IDynamixI985 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hi, I've tried adding sound effects for the “void” enemy, but I can't really say if they go well with the background music, since I'm not very familiar with these sound-related issues. I look forward to your suggestions so I can improve what I've done. |
|
Play this branch at https://play.threadbare.game/branches/IDynamixI985/void_sfx/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio Assets: Created the folder
assets/third_party/sounds/void_enemy/and added the audio files for idle, alert, chasing, caught, and defeated.Script (
void_spreading_enemy.gd):state_sounds: Dictionary[State, AudioStream]to map eachStatedirectly to anAudioStream._set_stateto setvoid_sfx.stream = state_sounds[state]and triggervoid_sfx.play().await void_sfx.finishedunderState.DEFEATEDto ensure the defeat audio finishes playing before proceeding.Animations: Updated the alert sound/keyframe in the
VoidSpreadingEnemyanimation.Audio for the void consuming tiles and props is still pending.