StoryQuests: Cleanup cinematics - #2852
Merged
Merged
Conversation
It was probably for exposing a texture variable in the cinematic dialogue, but is not assigned. So is safe to remove.
This is a duplicate of cinematicWithShake.gd, so reuse that one instead.
Which by the way was crashing because of a regression referencing GameState.intro_dialogue_shown, now in GameState.scene. Use the Cinematic node, and call the animation from the dialogue itself, not from a separate script.
|
Play this branch at https://play.threadbare.game/branches/endlessm/storyquests-cinematic/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
marked this pull request as ready for review
September 7, 2026 20:02
wjt
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legends Without Name: Remove custom cinematic
Which by the way was crashing because of a regression referencing
GameState.intro_dialogue_shown, now in GameState.scene.
Use the Cinematic node, and call the animation from the dialogue itself, not
from a separate script.
After The Tremor: Remove script extending Cinematic from combat scene
This is a duplicate of cinematicWithShake.gd, so reuse that one instead.
After The Tremor: Remove script extending Cinematic from intro scene
It was probably for exposing a texture variable in the cinematic dialogue, but
is not assigned. So is safe to remove.