Skip to content

Show area name when moving between areas - #2818

Open
renato-sy wants to merge 15 commits into
endlessm:mainfrom
renato-sy:main
Open

Show area name when moving between areas#2818
renato-sy wants to merge 15 commits into
endlessm:mainfrom
renato-sy:main

Conversation

@renato-sy

Copy link
Copy Markdown

Add an area name banner that appears when the player enters a new area. The banner is shown for a few seconds when moving between areas such as Fray's End and Song Sanctuary.
Resolves #2340

@renato-sy
renato-sy requested a review from a team as a code owner September 2, 2026 00:41
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Play this branch at https://play.threadbare.game/branches/renato-sy/main/.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@manuq

manuq commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

@renato-sy I see you continue pushing changes, so please let us know when you are ready to receive a review. Thanks!

@renato-sy

Copy link
Copy Markdown
Author

Okay, I think that's it; the pulls I was doing were just little things Git required to perform the merge.

@manuq

manuq commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

@renato-sy sorry for the delay. I wil have to review this on Monday. For the moment, please consider that there are other entry points to Fray's End:

  • From the east.
  • From the north (from Song Sanctuaries)
  • From the west (from Fray's End West, after completing the Void quest)
  • And another from the south (from Dev Archipelago, see image below)
image

I think entering from any of those should display the area name.

In fact all those have areas to block the exit, so maybe the entry areas should be next to them.

image

@renato-sy

Copy link
Copy Markdown
Author
Screenshot 2026-09-05 at 6 50 37 PM

Hey there! I've already mapped out the routes for Frays End, Frays End West, and Song Sanctuary, but I'm not sure where we could put the entrance to the area in Linenville—I don't see any villages or anything like that.

And I'm not sure if it's appropriate to also include the area alert when leaving a quest.

@wjt

wjt commented Sep 7, 2026

Copy link
Copy Markdown
Member

Linenville doesn't exist yet as an area you can walk to on the map - the upwards route in that screenshots is blocked even once you complete the void quest and push back that patch of void.

I personally wouldn't include the area name when leaving (i.e. abandoning?) a quest. At the end of a normal quest, when you're teleported back to the middle of Fray's End, I don't think the banner is needed. But I would include it when you first reach Fray's End at the end of the tutorial, i.e. at the spawn point circled at the bottom-left here:

image

@renato-sy

Copy link
Copy Markdown
Author

Okay, so Linenville isn't there. On the other hand—I don't know what you think about this—regarding the names that appear when entering an area, I placed it on the bridge, as if you were just arriving.

Screenshot 2026-09-07 at 1 11 42 PM

Just like in Song Sanctuary, I placed it on the bridge to indicate that the green section belongs to Routes or Fray's End, while the red part is a different area.

Screenshot 2026-09-07 at 1 16 53 PM However, if you'd like, I could set it up so that a notification showing the zone's name appears at the spawn points when the first move is made. And if so, would the animation be only once (the animation is instantiated and then destroyed; we would have to go to another area and re-enter the area to see the name) or many times (like it is now but in the spawn points)

reentry
Screenshot 2026-09-07 at 1 24 14 PM

first entry
Screenshot 2026-09-07 at 1 25 47 PM

@wjt

wjt commented Sep 8, 2026

Copy link
Copy Markdown
Member

Yes, the different-coloured grass on the two sides of the bridge is meant to mark the boundary to the Song Sanctuary, so I agree that the trigger should be crossing that bridge from bottom to top!

@renato-sy

Copy link
Copy Markdown
Author

Okay, so are we all set, or do I need to make any changes?

@wjt

wjt commented Sep 8, 2026

Copy link
Copy Markdown
Member

Sorry, I have not tested or reviewed the code changes yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show area name when moving between areas

4 participants