Repository navigation
Update numpy to use OpenBLAS - #6310
Conversation
7699d85 to
44751df
Compare
1f96e83 to
1e3df8c
Compare
|
SciPy is not rebuilt in this PR. For now we only want to verify that the NumPy test suite passes ( |
c76e4cf to
722c40c
Compare
|
Compared
The extra four control failures are the print round-trips already skipped here ( |
5322539 to
a6a0cb9
Compare
|
Rebased onto #6676 so this PR only applies the OpenBLAS switch:
Review the OpenBLAS delta at jjerphan/recipes@numpy-run-full-test-suite...numpy-use-openblas |
a6a0cb9 to
85103b1
Compare
|
Rebased onto the updated #6676 after that PR was rebased onto main. |
163b8e6 to
03d40a9
Compare
Port the experimental numpy-openblas recipe into numpy so the default package uses OpenBLAS for BLAS and LAPACK, and drop numpy-openblas. Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
The OpenBLAS-linked rebuild follows the full-suite rebuild at build 2. Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
ianthomas23
left a comment
There was a problem hiding this comment.
Thanks @jjerphan.
In particular thanks for the copious clear documentation making it easy to review.
Summary
Follow-up to #6194. Based on main after Update numpy to run the full test suite #6676 (itself after Add numpy-tests #6610).
This PR only switches the official
numpyrecipe to OpenBLAS and removesnumpy-openblas. Thenumpy-testssplit andnp.test(label="full")runner already landed in the PRs above.The default
numpypackage now uses OpenBLAS for BLAS and LAPACK (-Dallow-noblas=false), with the flang Fortran ABI patch and the BLAS/LAPACK smokes from #6194. SciPy could be tested against the new builds of OpenBLAS (see #6320).Template B: Checklist for updating a package
PR Formatting
Add [package-name]orUpdate [package-name] to [version]Package Details
Build Notes
Same considerations as #6194:
openblasscipy-openblas.pcalias so Meson skips wasm-ld-breaking OpenBLAS symbol probes0002-Match-flang-OpenBLAS-Fortran-ABI-on-Emscripten-wasm32.patchfor flang CHARACTER lengths and void subroutine returns0003-Silence-clang-warnings-on-Emscripten-wasm32.patchfor emcc/clang 21 diagnostics (32-bitnpy_uintpvsINT64_MAX, unused CPU-dispatch helpers, int-max to float rounding). Not OpenBLAS-specific.show_configBLAS/LAPACK, matmul, Cholesky, solve, and eigh onnumpyWasm test skips and the
numpy-testssuite runner are in #6676. The experimental-channel tag fromnumpy-openblasis not copied; this targets the main channel.