Remove PTHREAD_POOL_SIZE form node tests. NFC#26932
Merged
Merged
Conversation
sbc100
force-pushed
the
node_tests_pool_size
branch
3 times, most recently
from
9230551 to
fb466a7
Compare
Node workers can start synchronously so there should be no need for this setting in any node tests. I'm not sure how we ended up with so many occurrences here.
sbc100
force-pushed
the
node_tests_pool_size
branch
from
fb466a7 to
fc8cf8b
Compare
dschuff
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node workers can start synchronously so there should be no need for this setting in any node tests. I'm not sure how we ended up with so many occurrences here.
This should also speed up the posixtestsuite since (under node) we now just create threads on demand.