Fix broken relative README links on crates.io#247
Open
Burrdi wants to merge 1 commit into
Open
Conversation
The README is published from the repo root but crates.io resolves relative links against the crate manifest dir (egui_plot/), producing 404s. Use absolute github.com/.../blob/main/ URLs instead.
|
View snapshot changes at kitdiff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README is published to crates.io from the repo root (
readme = "../README.md"inegui_plot/Cargo.toml), but crates.io resolves relative links against the crate's manifest directory (egui_plot/) instead of the README's actual location. That injects an extraegui_plot/path segment, so the links 404 on the crate page.Links as rendered on crates.io today (all 404):
ECOSYSTEM.md->.../blob/HEAD/egui_plot/ECOSYSTEM.mdCONTRIBUTING.md->.../blob/HEAD/egui_plot/CONTRIBUTING.mdWELCOME_CONTRIBUTIONS.md->.../blob/HEAD/egui_plot/WELCOME_CONTRIBUTIONS.mdFix: use absolute
https://github.com/emilk/egui_plot/blob/main/<file>URLs, which resolve on both crates.io and GitHub (all return 200). Rendering on GitHub is unchanged.